search

iho-ohi / S-101-Documentation-and-FC

Repository issues of S-101 document and feature catalogue
22 stars 5 forks source link

`fileLocator` attribute #162

Open DavidGrant-NIWC opened 1 month ago

DavidGrant-NIWC commented 1 month ago

image

  1. Reference to S100_SupportFileFormat should be to S-100 Part 17 clause 17-4.5 Elements of the Exchange Set Catalogue (pg. 23 in 5.1).
  2. "ASCII" should be "TXT_UTF-8"
  3. The offset for TXT_UTF-8 is ambiguous and is not well formed.
    • It appears to specify a character offset (the n'th character in the file), but UTF-8 encodings may contain multi-byte characters.
    • It encodes an integer value in a text field.
      • Recommend that for consistency with the other formats that an appropriate text pattern is provided instead of an offset.
    • If the offset value is retained, clarify that the value is a byte offset, not a character offset.
rmalyankar commented 1 month ago

Recommend prohibiting the use of fileLocator with TXT_UTF-8 files.

MikusRL commented 3 weeks ago

Added in redline proposal to #159