iho-ohi / S-101-Documentation-and-FC

Repository issues of S-101 document and feature catalogue
23 stars 5 forks source link

marks navigational – system of & Preferred Channel marks #67

Closed alvarosanuy closed 11 months ago

alvarosanuy commented 1 year ago

Refer to https://github.com/S-101-Portrayal-subWG/Working-Documents/issues/79 PsWG decision comment made on 22/5/23. Note that a new range of coloured navmarks symbols have been introduced in S-101 and that the mapping of the correct 'preferred channel mark' symbol would significantly benefit from some modelling changes and additional encoding guidance.

The PsWG asks the DCEGsWG to :

  1. Include the attribute "marks navigational – system of" in VirtualAISAidToNavigation in order to assist with the mapping of the correct 'preferred channel mark' symbol. Although this task can be resolved by LUA scripts, the preferred option is to avoid performing topological tasks during the portrayal building.

  2. Making the encoding of the attribute "marks navigational – system of" mandatory when 'category of lateral mark' = 3 or 4 OR 'virtual AIS aid to navigation type' = 7 or 8.

JeffWootton commented 1 year ago

for (1): Note that in S-101 Edition 1.1.0 there was an error for attribute virtualAISAidToNavigationType values 5-8, which has now been corrected in the draft S-101 DCEG Edition 1.2.0 to correctly align with the corresponding encoding for the S-57 Object class NEWOBJ: virtualAISAidToNavigationType

This correction was approved at the S-101PT10 meeting (June 2023). Given that this correction now includes the relevant IALA buoyage system as part of the attribute values and there are no longer values for "preferred channel" marks (which also aligns with IMO), there is no longer a requirement to add the attribute marksNavigationalSystemOf to the VirtualAISAidToNavigation feature. Therefore suggest that no further action is required.

For (2): The overall indication of the buoyage system for a dataset is indicated by the value of marksNavigationalSystemOf on the mandatory Meta feature NavigationalSystemOfMarks; and it is prohibited to populate marksNavigationalSystemOf on individual Geo features if the value is the same as for the underlying NavigationalSystemOfMarks feature. Therefore, if a preferred channel lateral mark is aligned to the overall system, then it is prohibited to populate marksNavigationalSystemOf on the feature itself. Therefore mandating marksNavigationalSystemOf as suggested will not work in most cases.

The only way that I can see the correct symbol being displayed if the portrayal is to be entirely based on the value populated for categoryOfLateralMark is if the selected symbol is also somehow associated to the value populated for marksNavigationalSystemOf on the underlying NavigationalSystemOfMarks feature. [By the way - this will be the case for all values of categoryOfLateralMark.] This needs to be noted https://github.com/S-101-Portrayal-subWG/Working-Documents/issues/79.

To be discussed by DCEG Sub-Group.

alvarosanuy commented 1 year ago

@JeffWootton - Sorry I was not present when this topic was discussed at S101PT10 and I may be missing or misinterpreting something here but, based on the new list of values for virtualAISAidToNavigationType, are we now saying that IALA/IMO do not support the 'preferred channel' concept for V-AIS?

If this is the case, this issue can be closed as we won't be using the V-AIS preferred channel symbols that we had developed (see below). image

The concept certainly exists for physical buoys and beacons and they have their unique symbology depending on the IALA system in force. For physical navaids the right symbology can be implemented by linking categoryOfLateralMark and marksNavigationalSystemOf (see DCEG table below).

image

JeffWootton commented 11 months ago

Discussion at S-101 DCEG Sub-Group 4 meeting:

Points to Note:

Discussion/Decision:

Action: - Report to S-101PT11 and close Issue (IHO Sec).

No further discussion at S-101PT11. Close Issue.