search

iho-ohi / S-101-Test-Datasets

A repository of S-101 test datasets which make available for development phases and they will be migrated to the Registry later.
24 stars 6 forks source link

CATALOG.XML protectionScheme present with dataProtection = false #16

Closed DavidGrant-NIWC closed 1 year ago

DavidGrant-NIWC commented 1 year ago

datasetDiscoveryMetadata.protectionScheme is an optional field. It should not be present when dataProtection is set to false.

kusala9 commented 1 year ago

agree. Will modify CATALOG.XML accordingly.

kusala9 commented 1 year ago

done for version 2.0. Actually, as this is an optional field it's not a problem if it's there for unencrypted data is it? The boolean flag asserts whether something is encrypted, this one just holds a name of an encryption scheme. Suggest this is actually not that useful at all really.... :-)

DavidGrant-NIWC commented 1 year ago

There are many unnecessary fields like this. I agree, the presence or absence of protectionScheme should be sufficient to determine if the data is encrypted. I also agree that the original encoding is not wrong, it just looks odd and could indicate a user error where the boolean flag is set to the incorrect value.

kusala9 commented 1 year ago

close this one. I believe the exchange sets produced in the S-164 repo will only use this field when cells are encrypted. If it persists it can be re-raised in the S-164 repo.