iho-ohi / S-101-Test-Datasets

A repository of S-101 test datasets which make available for development phases and they will be migrated to the Registry later.
22 stars 6 forks source link

S-164_1.1/V2/3.1 ENC Display/Other/Mangrove #64

Open plebihan29n opened 10 months ago

plebihan29n commented 10 months ago

Some S57 Mangrove instance (VEGATN,CATCOV7) have been encode in the test dataset "AA5OTHER". These kind of features could be converted to S101 Obstruction feature if they overlap "depth " areas. This is not the case in this dataset as they overlap "land area"

Proposal : Move these instance in order to overlap some depth areas ? mangrove

DavidGrant-NIWC commented 10 months ago

Could be useful for checking alerts and ensuring portrayal matches expectations. image

plebihan29n commented 9 months ago

This proposal has been encoded in the delivered version 3 of S-164

DavidGrant-NIWC commented 9 months ago

It's there, but it doesn't match the encoding guidance:

image

Also, recommend adding a mangrove point: image

plebihan29n commented 8 months ago

The content of the dataset has been modified taking account your proposal. In addition I have also qualify with horizontal measurement = 4 (approximate), the spatial object that is shared with the coastline and with the mangrove

plebihan29n commented 8 months ago

Capture d’écran de 2023-10-28 08-01-34

DavidGrant-NIWC commented 8 months ago

Recommend adding an additional feature

Data quality issue

Minor encoding issues applicable to point and area objects

plebihan29n commented 8 months ago

1 : I find strange to not encode quality of measurement on the coastline even if the "mangrove area" is now in the display base display category (!= S-52). This quality information could be confirm that the coastline is not accurate. 2 : You write "I don't think default clearance depth should be populated (because the feature is not underwater):" : is it a rule from the DCEG ? . Perhaps could be useful to encode it for example ? if yes , I guess that the value is -5m as I have encode a height of 5m 3 : In this dataset , we have an another "mangrove area" , I propose to encode it along the coastline as "apparent coastline" due to generalization (for example again), do you think this could be useful ?

DavidGrant-NIWC commented 8 months ago

3 : In this dataset , we have an another "mangrove area" , I propose to encode it along the coastline as "apparent coastline" due to generalization (for example again), do you think this could be useful ?

Yes.

For 1 and 2, I guess those are questions for the DCEG group / Jeff W.

plebihan29n commented 8 months ago

The current encoding of "mangrove area" as an obstruction.

mangrove-area

plebihan29n commented 8 months ago

The current encoding of "mangrove line" as a coastline. mangrove-line

DavidGrant-NIWC commented 8 months ago

Looks good other than the outstanding DCEG questions