search

iho-ohi / S-101_Portrayal-Catalogue

Space to discuss and review IHO S-101 Portrayal Catalogue
32 stars 12 forks source link

“system” attribute flare bearing [PSWG #161, Row 10] #361

Closed mikan66 closed 4 months ago

mikan66 commented 7 months ago

image

mikan66 commented 4 months ago

S-101PT13 decision: Bring back CSP, revert other changes associated with removal of CSP and re-test CSP.

alvarosanuy commented 4 months ago

HI @mikan66 - By reading the latest DCEG, the population of 45 degrees or 45/135 degrees on coincident lights, is to be done by the Production Tool (e.g. CARIS). Consequently, the PC Rule should either point the flare at 45 degrees when the attribute is empty or towards the direction populated in the flareBearing attribute (either auto populated by the Prod. tool or modified by the cartographer). Is this not what you guys had in PC 1.3.0?? image

mikan66 commented 4 months ago

@alvarosanuy, 1.3 had: if flareBearing defined, rotation = feature.flareBearing.

alvarosanuy commented 4 months ago

@JeffWootton - @DavidGrant-NIWC Is the wording of DCEG 1.4.0 in accordance with Decision made at S101PT13? It looks it continues referring to the attribute as a 'system' one and requires Production Tools to manage coincident lights. Equally the software could populate the default angle when no coincident lights exist.... Portrayal rule would only say 'point the flare' as per flareBearing value (this will cover manual updates by cartographers). Just trying to make sense between what is currently in PC 1.3.0 and what is expected for 1.4.0. Maybe is just me because I was not at the meeting during the discussion of this topic. If we want Production tools to 'do nothing' then we can't call the attribute a 'system' attribute and the wording of the DCEG needs to be removed. Then we would make sure CSP is fully implement by the PC.

JeffWootton commented 4 months ago

@alvarosanuy you are correct. The attribute should be amended to be a feature attribute rather than a system attribute - I should have taken an action to do this at S-101PT13. It will be amended for Edition 1.4.1.

This will not impact FC development as there is no method in the FC for indicating the nature of an attribute (feature, system, ...).

alvarosanuy commented 4 months ago

All good, thanks Jeff.