search

iho-ohi / S-102-Product-Specification

It is opened to develop S-102 Bathymetric Surface Product Specification. The contents of this repository are not offical publication in force, therefore please check the final version on the IHO website.
Other
27 stars 11 forks source link

Developing #24

Closed hasel001 closed 1 year ago

hasel001 commented 1 year ago

Includes Raphael edits (via Word) circa 24 January 2023 and Svein previously adopted changes resubmitted to Lawrence around PT11. Annexes for feature catalogue and gridding method were removed.

rmalyankar commented 1 year ago

Includes Raphael edits (via Word) circa 24 January 2023 and Svein previously adopted changes resubmitted to Lawrence around PT11. Annexes for feature catalogue and gridding method were removed.

There are a few discrepancies between my edits and the 9 February Github adoc version in clause 12, for example a note I deleted in the S100_ProtectionScheme table is apparently still there.

hasel001 commented 1 year ago

@rmalyankar Thanks for catching that missed deletion. I fixed it along with a couple of "Note" elements that had been appearing in one cell at the bottom of the nearest table instead of below the entire table.

The PDF generated in the github_pages.zip artifact is quite broken--it is over 500 pages due to many table cells insisting upon occupying one line by themselves.

The Word doc is far from perfect, but it is beginning to resemble our Spec.

ronaldtse commented 1 year ago

@hasel001 I'd like to mention that there is one validation error in the document:

Anchors: (XML Line 001340): Crossreference target tab-codes-defining-how-uncertainty-was-determined is undefined

It looks like a table is missing in the document?

hasel001 commented 1 year ago

@ronaldtse Thanks for catching that. I had erroneously put in two different names when referring to that table.

hasel001 commented 1 year ago

@rmalyankar , thank you very much for the changes summary you sent me. I have incorporated it into the Document History section. As we continue considering rolling all these changes into the main branch, please review and comment on the updated Document History. Thank you!