search

iho-ohi / S-102-Product-Specification

It is opened to develop S-102 Bathymetric Surface Product Specification. The contents of this repository are not offical publication in force, therefore please check the final version on the IHO website.
Other
27 stars 11 forks source link

Clause 5.1 "association role" #53

Closed rmalyankar closed 6 months ago

rmalyankar commented 11 months ago

Clause 5.1, 2nd para:

Note the vertical datum is defined through a second association role to a vertical reference system.

S-102 Edition 2.2.0 does not use association roles to indicate datums. Either:-

RohdeBSH commented 10 months ago

I am for the second option

  • revise it to say the vertical datum is specified separately in the root group attributes (or words to that effect)
HolgerBothien commented 10 months ago

Another point, may not fit directly to this: In table 8 for vertical Datum it says: Numeric code from IHO GI Registry Vertical Datum attribute except

It would be better to have a positive list of values that are allowed instead of refering to a living docoment where every day new values can appear.

rmalyankar commented 10 months ago

I opened a new issue for this suggestion.

Another point, may not fit directly to this: In table 8 for vertical Datum it says: Numeric code from IHO GI Registry Vertical Datum attribute except

  • 47 (seaFloor)
  • 48 (seaSurface)
  • 49 (hydrographicZero).

It would be better to have a positive list of values that are allowed instead of refering to a living docoment where every day new values can appear.

rmalyankar commented 8 months ago

Since there are no further comments, I assume there are no obhection to the second choice. Recommended substitute language: The vertical datum is specified separately using other root group attributes.

hasel001 commented 6 months ago

I implemented the change as agreed in PT15. Thanks to all who participated in the work and the discussion!