Open rmalyankar opened 1 year ago
I'm not sure what is technically the best way to make the material available for PT review. Theoretically the files and diffs in the pull request can be viewed in Github and presumably with tools connected to Github(?) (and I think the Excel spreadsheet can be downloaded from the pull request).
Procedurally, I think the September meeting should plan for how and when to review it.
@rmalyankar I recommend we send out a copy of the spreadsheet before S-102PT14 (4 Sep) to ensure widest dissemination. I will add an agenda item for us to refine our procedure (hopefully to obviate the need for sending separately in the future).
@hasel001 I'm OK with sending the spreadsheet out. The check format is explained in the text of the new Annex, if anybody asks.
You can download the spreadsheet from the validation checks pull request itself: -> Files changed -> view the Excel file -> download. If that doesn't work let me know and I will email a copy.
By the way, are there other pull requests which have not yet been merged with the Developing branch? If so you will probably need to check for conflicts when it comes to merging.
At some point the S-102 PT will still have to work on product-specific validation checks, but note that there have been significant developments since these validation checks were first posted, with respect to S-102 itself (notably, multiple vertical datums!) and also with respect to the S-158 series. In other words, some (though not all) of the original spreadsheet has either already become obsolete or will soon be obsolete. Nevertheless, it is still useful to have a list of validation checks even if it is not entirely up-to-date, so the S-102 PT may wish to retain the spreadsheet on GitHub as an informative though partially obsolete guideline.
I have just created a pull request to add the Validation Checks Annex I mentioned to @hasel001 and @AnnaWall01 in the Developing/2.3.0 folder, along with an accompanying spreadsheet with the detailed checks. Also some minor changes to other documents (fixing a typo in clause 10 and adding the new annex to the manifest for the whole PS document).
The new content annex and spreadsheet are in draft form. (I don't anticipate making anything more than minor corrections before the September '23 VTC).
The checks do not duplicate "S-100 level" checks being drafted by the S-100 Validation checks sub-group: