iho-ohi / S-102-Product-Specification

It is opened to develop S-102 Bathymetric Surface Product Specification. The contents of this repository are not offical publication in force, therefore please check the final version on the IHO website.
Other
28 stars 11 forks source link

ExchangeSet <> ProductSpecification - Difference in version number #91

Closed RohdeBSH closed 4 months ago

RohdeBSH commented 5 months ago

Hi,

We have noticed that the version number of the product specification in the ExchangeSet is different from the HDF5 file. In the ExchangeSet the version number of the PS is complete, i.e. Major, Minor & Bugfix (NewEdition, Revision, Clarification). In the HDF5 file, however, only Major & Minor (NewEdition, Revision) are given. The background is certainly a not quite so well done example from the S-100 ed 5.0.0 Table 10c-6 row 1.

From our point of view, it makes sense and is necessary to change the example in the S-102 so that the HDF5 file and the ExchangeSet have the same content.

ExchangeSet: 020200 -> corresponds to 2.2.0

HDF5 file: INT.IHO.S-102.2.2 -> The bugfix (clarification) is missing here

Our suggestion would be to change the example and include the bugfix (clarification). Change to INT.IHO.S-102.2.2.0

PS_HDF5_Version

https://github.com/iho-ohi/S-102-Product-Specification/blob/cffb0c33b6873d9a0ebcb61117a0e130c56d1c64/sources/3.0.0/sections/10-data_product_format.adoc?plain=1#L191C1-L191C27

@AnnaWall01 @hasel001 Do we need an extra change proposal document for this minor change?

RohdeBSH commented 4 months ago

Merge done