search

iho-ohi / S-129-Product-Specification

IHO Repository to discuss technical issues of development of S-129 Product Specification.
9 stars 4 forks source link

Need for attributeVisibility binding? #16

Closed jrhee01 closed 4 months ago

jrhee01 commented 4 months ago

It is noted that (1) most of the S-129 attributes are not required to be of "protected" or "private" visibility, and (2) attributeVisiblity is an optional binding.

However, it is also noted in S-101 FC that interoperabilityIdentifier has privateVisibility binding. If it is appropriate for interoperabilityIdentifier to be of privateVisibility, then the same can be incporated into S-129 FC.

jrhee01 commented 4 months ago

As per issue 14 (https://github.com/iho-ohi/S-129-Product-Specification/issues/14), interoperabilityIdentifier has been set to privateVisibility, Refer to commits 04ed3ab56ac7b6388d84193cc6278bdcba029470 and 826dfd0a3d3ddd57a556986f0a565439ecc1206b.