iho-ohi / S-129-Product-Specification

IHO Repository to discuss technical issues of development of S-129 Product Specification.
7 stars 4 forks source link

Validation report from 1.3.0/PC/S-129_PC_Text #21

Open DavidGrant-NIWC opened 1 month ago

DavidGrant-NIWC commented 1 month ago

===> VerifyPCFilePresence() processing... File ColorProfiles\s100ColorProfile.xsd not referenced by Portrayal Catalog. File ColorProfiles\svgStyle.css not referenced by Portrayal Catalog. File ColorProfiles\svgStyle_.css not referenced by Portrayal Catalog.

===> VerifyPCIDs() processing...

===> VerifyPCViewingGroups() processing...

===> VerifyRules() processing... Rules file for UnderKeelClearancePlan not found. Rules file ........\FCAndPCToCheck\PortrayalCatalog\Rules\AlmostNonNavigableArea.xsl contains a BOM. Rules file ........\FCAndPCToCheck\PortrayalCatalog\Rules\ControlPoint.xsl contains a BOM. Rules file ........\FCAndPCToCheck\PortrayalCatalog\Rules\InformationBox.xsl contains a BOM. Rules file ........\FCAndPCToCheck\PortrayalCatalog\Rules\main.xsl contains a BOM. Rules file ........\FCAndPCToCheck\PortrayalCatalog\Rules\PlannedRoute.xsl contains a BOM.

===> VerifyResourceUsage() processing... AreaFillReference ANA not referenced in rules. AreaFillReference NNA not referenced in rules. LineInstruction ROUTE not referenced in rules.

===> VerifySchemas() processing...

jrhee01 commented 1 month ago

Thanks @DavidGrant-NIWC for running the validation and providing the report. Apologies again that I hadn't merged the latest PC changes into the main branch.

This merge has been done now, and the "S-129_PC_Text" and "S-129_PC_Boolean" versions are removed as part of the merge.

Regardless, most of the validation report still stands, and corresponding changes have been made on branch "21-validation-report-from-130pcs-129_pc_text" as follows:

  1. Rules with BOM have been resaved with UTF-8 (w/o BOM)
  2. The unused files under ColorProfiles have been removed
  3. The unused ROUTE linestyle file has been removed (ANA and NNA area fills had already been removed on branch #18)

Much appreciated if you could review the changes committed on "21-validation-report-from-130pcs-129_pc_text"

DavidGrant-NIWC commented 1 month ago

See https://github.com/iho-ohi/S-129-Product-Specification/issues/22#issuecomment-2346477703