search

ihor / react-native-scalable-image

React Native Image component which scales width or height automatically to keep the original aspect ratio
https://www.npmjs.com/package/react-native-scalable-image
MIT License
315 stars 67 forks source link

Infinite loop from useEffect() #24

Closed mqtik closed 3 years ago

mqtik commented 4 years ago

Memory leak detected. Passing an empty array as the second argument to useEffect makes it only run on mount and unmount, thus stopping any infinite loops.

thijssmudde commented 4 years ago

Can this be merged please? The console error pops up all the time.

ihor commented 3 years ago

Thanks @mqtik !