search

ihordiachenko / eslint-plugin-chai-friendly

Makes eslint friendly towards Chai.js 'expect' and 'should' statements.
MIT License
53 stars 10 forks source link

Improve `.npmignore` to exclude eg. `.nyc_output` #24

Closed voxpelli closed 6 months ago

voxpelli commented 3 years ago

This reverts the .npmignore to ignore everything except for the very files that needs to be included. Thus fixes the fact that eg. .nyc_output gets published to npm.

Reason why .nyc_output is currently published to npm is that .npmignore replaces .gitignore, rather than extends it.

Edit: Here's a link to the Renovate diff where I found out that this was happening: https://app.renovatebot.com/package-diff?name=eslint-plugin-chai-friendly&from=0.6.0&to=0.7.2

ihordiachenko commented 3 years ago

Hi @voxpelli. I think it would be cleaner to use "files" field in package.json to explicitly whitelist the source files

voxpelli commented 3 years ago

I agree @ihordiachenko, then if you publish using eg np, then it can check with you whether it’s correct or not that a bee files is included or excluded 👍

Should I change this PR to files?

ihordiachenko commented 3 years ago

@voxpelli yes, update the PR and I'll merge it

voxpelli commented 7 months ago

@ihordiachenko 3.5 years later and I have now done so, sorry for delay 🙈

ihordiachenko commented 6 months ago

@voxpelli be like: image

Lgtm. Will include in the next release