search

ihormelnyk / opentherm_library

Arduino/ESP8266/ESP32 OpenTherm Library for HVAC system control communication
MIT License
207 stars 91 forks source link

Can't build in Platformio, getTemperature is missing in cpp #27

Open ZzubbuzZ opened 3 years ago

ZzubbuzZ commented 3 years ago

I download the master version of your lib to my project (I'am using platformio 5.0.1), I'm just updating an existing project that used OpenTherm::getTemperature(). The signature OpenTherm::getTemperature is present in your headers (l153), but not in your cpp...??

I fix it by adding this :

float OpenTherm::getTemperature(unsigned long response) {
    float temperature = isValidResponse(response) ? getFloat(response) : 0;
    return temperature;
}
warnerthuis commented 3 years ago

Is a fix coming for this error?

ihormelnyk commented 3 years ago

getTemperature is obsolete and should be removed use getFloat function to parse response

Chupaka commented 3 years ago

https://github.com/ihormelnyk/opentherm_library/commit/908d43d7048ab51e003a40d195959a8624942a20 fixed this, so the issue should be closed, I believe?