search

ihormelnyk / opentherm_library

Arduino/ESP8266/ESP32 OpenTherm Library for HVAC system control communication
MIT License
224 stars 94 forks source link

Not compiling when "thingProperties.h" is used. #54

Open vdv-k opened 1 year ago

vdv-k commented 1 year ago

When using

include "thingProperties.h"

include

an error is generated when compiling the code. There seems to be a redeclaration of ' READ' (already used in ThingProperties).

Probably easy to solve but I'm new to all this and don't know how. Any suggestions welcome.

Laxilef commented 10 months ago

Hey See this PR: https://github.com/ihormelnyk/opentherm_library/pull/57

4310benno commented 9 months ago

Same problem for me in iotCloud : caused by Read definition in Opentherm.h made for "backards compatability". Solution for the time can be : comment out Read and Write declaration, and change READ in the CPP file to READ_DATA, and upload the library to IOT cloud in a zip

Laxilef commented 9 months ago

@4310benno did you use the version from the master branch?

4310benno commented 9 months ago

Yes, and for me it is working now. Only waiting for your shield to arive😀

Benno

Verstuurd vanaf mijn iPad

Op 2 feb. 2024 om 22:38 heeft Laxilef @.***> het volgende geschreven:



@4310bennohttps://github.com/4310benno did you use the version from the master branch?

— Reply to this email directly, view it on GitHubhttps://github.com/ihormelnyk/opentherm_library/issues/54#issuecomment-1924735446, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALLMRTEVQPS6VUZP5PCF4LTYRVMDLAVCNFSM6AAAAAA65PTZOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUG4ZTKNBUGY. You are receiving this because you were mentioned.Message ID: @.***>