Missing generic type for BasePresenter

ihorvitruk / buddysearch

Android Clean Architecture example using MVP, Rx: RxJava, RxAndroid, Dagger 2, Data Binding, Retrolambda, Firebase Database, Firebase Auth, Firebase Messaging (FCM), Realm

Apache License 2.0

208 stars 45 forks source link

Missing generic type for BasePresenter #12

Open IonutNegru87 opened 6 years ago

IonutNegru87 commented 6 years ago

BaseActivity should declare the generic type for BasePresenter also. It should be:

public abstract class BaseActivity<VIEW extends View,
        PRESENTER extends BasePresenter<VIEW>,
        BINDING extends ViewDataBinding> extends AppCompatActivity
        implements LoaderManager.LoaderCallbacks<PRESENTER> {

This will also fix any issues with: "Unchecked call to as a member of raw type"