ihsanbal / LoggingInterceptor

An OkHttp interceptor which has pretty logger for request and response. +Mock support
MIT License
1.33k stars 112 forks source link

Why is .addQueryParam("query", "0") in the readme? #60

Closed z3ntu closed 4 years ago

z3ntu commented 4 years ago

Hi, in the project I'm working on, somebody copied the usage of this library including the .addQueryParam("query", "0") statement which now broke because an API endpoint checked for allowed url parameters - and query=0 isn't allowed - so it broke.

Any reason this is in the 'Usage' section of the readme (where blindly people copy-paste from)?

ihsanbal commented 4 years ago

@z3ntu .addQueryParam("query", "0") function in readme file is just sample which shows you that you can add query param to all your requests like apiKey and other default things. So you better to remove it if you don't need it.