search

ii8 / havoc

minimal terminal emulator for wayland
Other
103 stars 17 forks source link

ability to set app_id #28

Closed sijad closed 4 years ago

sijad commented 4 years ago

it'd be useful to be able to set the app_id via options.

I use app_id to set options to specific app_id.

sijad commented 4 years ago

I can send an PR, if you think this can be useful

ii8 commented 4 years ago

Yeah, that makes sense. I would merge that. Does it need to be configurable though? I think you can just hardcode it to "havoc".

sijad commented 4 years ago

I'm not sure what do you mean by hardcodding it? you mean I have to have two havoc? one of them with hard codded job_id?

ii8 commented 4 years ago

Hardcoding just means it's not configurable via the command line options or havoc.cfg, it's just always set to "havoc". No, just one havoc.

Look in xdg-shell.h, it can be set with just one function call.

sijad commented 4 years ago

In that case I have to have multiple instance of installed havoc. you can set app_id in termite using --name option.

and I'm not sure have that in config file would be useful either.

this is my changes: https://github.com/sijad/havoc/tree/app-id

ii8 commented 4 years ago

Oh, I see, you want to distinguish havoc instances. Ok sure, have a command line option for it. But it should default to "havoc".