search

ii8 / havoc

minimal terminal emulator for wayland
Other
103 stars 17 forks source link

Support make --prefix=... and make DESTDIR=... ? #7

Closed kindaro closed 5 years ago

kindaro commented 5 years ago

Thank you for your great work on this program! I can give a testament that it works great, and fast.

I was trying to package it for my operating system (that would be Arch Linux) and it appears to me that there is no support for building into a temporary location.

  1. The usual way to set the location from which a program will be run is to issue ./configure --prefix ..., as described, for instance, here. But there is no configure script and make does not understand this parameter either.
  2. The usual way to build into a temporary location is to issue make DESTDIR=... install, as described, for instance, here. But it appears to me that this option is ignored.

Now, I was able to build the program into a temporary location by editing Makefile by hand and changing the value of PREFIX, but I would not like to use sed to correct this value every time I want to update my package.

If you could arrange it so that make install understands DESTDIR and that make understands prefix, I am sure many people will be able to enjoy the fruits of your work with greater ease.

ii8 commented 5 years ago

Hello, I'm glad you like it. In make you can actually set any of the variables on the command line, see here

And DESTDIR is now respected in the makefile, so you can write:

make DESTDIR=... PREFIX=... install
kindaro commented 5 years ago

Great! Now there is a package in Arch User Repository.