iiab / calibre-web

:books: Web app for browsing, reading and downloading eBooks stored in a Calibre database
GNU General Public License v3.0
4 stars 5 forks source link

"Test at least 10 different Vimeo video downloads" #171

Open holta opened 5 months ago

holta commented 5 months ago

@deldesir @EMG70 if you have time❔

If so please post full results ("Tasks" view screenshot and iiab-diagnostics pastebin URL) after attempting to "Download to IIAB" 10 different Vimeo videos.

🌎 🌍 🌏

Related:

EMG70 commented 5 months ago

SUDO IIAB-DIAGNOSTICS : https://dpaste.com/BDRX23TF6 11 Vimeo videos downloads attempted: https://vimeo.com/539844075 How feed prices will impact the broiler industry βœ… https://vimeo.com/5282155 Sewing βœ… https://vimeo.com/53301442 Cheese βœ… https://vimeo.com/228341694 Networking βœ… https://vimeo.com/953721938 Sql intro (Failed to download,non susbscriptable) ,not a calibre web problem.output message says Video is not rated. Log in to watch.? ❌ see screenshot Screenshot from 2024-06-05 19-32-24

https://vimeo.com/498384180 IoT , video downloaded without cover ❌ https://vimeo.com/255959106 Data basics βœ… https://vimeo.com/134138657 IoT: How Data Science-Driven Software is Eating the Connected World βœ… https://vimeo.com/461859027 Beef efficiency ,video downloaded without cover ❌ https://vimeo.com/447360211 Avocado grafting βœ… https://vimeo.com/222794361 Papaya βœ…

Pasted image Screenshot from 2024-06-05 19-09-28 The two videos that did not show thumbnails were uploaded by SRUCBytes - Scotland's Rural College.

holta commented 5 months ago

THANK YOU @EMG70 for your hard work πŸ™

Summary needing investigation:

8 βœ… 2 ⚠️ thumbnail missing 1 ❌ "failed to download: 'NoneType' object is not subscriptable"

See also: https://github.com/iiab/calibre-web/issues/167#issuecomment-2147702760

holta commented 5 months ago

@EMG70 would you have time to repeat any similar test, trying to download 10 Vimeo videos and also a Vimeo showcase (i.e. playlist) ?

Reason is that related PRs have just been merged:

As included in the just-published IIAB Calibre-Web weekly release:

avni commented 5 months ago

Testing Jun 8, 2024 12pm ET - Individual Videos

iiab-diagnostics: https://dpaste.com/BBFFWJ7PQ

4 Vimeo video downloads attempted (3 from @EMG70 's list and 1 different one)

1 YouTube video

2 Bilibili videos

Summary of testing:

More next on Playlists/Showcases/Anthologies and Channels

holta commented 5 months ago
  • https://vimeo.com/953721938 [Introduction to SQL] ❌

    • Same error as @EMG70's. Log: [2024-06-08 13:07:30,650] ERROR {cps.tasks.download:122} An error occurred during the subprocess execution: 'NoneType' object is not subscriptable
  • https://vimeo.com/498384180 [SRUCBytes 3 - IoT] πŸ₯‰

    • Download successful, but no cover image. Same as @EMG70

@deldesir both errors above appear to be identical to @EMG70's test results 3 days prior:

Is this expected?

deldesir commented 5 months ago

Bilibili errors are expected due to https://github.com/yt-dlp/yt-dlp/issues/10121. Vimeo ones need further investigation. I'll make an enhancement right away to read the error reported by yt-dlp (via xklb) instead of the exception at runtime.

deldesir commented 5 months ago

Cover for https://vimeo.com/498384180 went missing because it was placed in another directory.:

root@box:/usr/local/calibre-web-py3/cps/tasks# tree Vimeo/
Vimeo/
β”œβ”€β”€ Scotland's Rural College
β”‚Β Β  └── 498384180.jpg
└── Scotlands Rural College
    └── SRUCBytes 3 IoT_54.00_[498384180].mp4

3 directories, 2 files
holta commented 5 months ago

Many thanks to @chapmanjacobd for shining a light on the punctuation problem: (e.g. single quote in "Scotland's" above)

avni commented 5 months ago

Testing Jun 8, 2024 5pm ET - YouTube Playlist

iiab-diagnostics: https://dpaste.com/HE465LXDW

I downloaded a playlist of 15 vidoes: LINK. 14 downloaded successfully, 1 had its thumbnail missing.

I liked that a Shelf for the playlist was automatically created so I can find these specific videos grouped together easily. It would be helpful to make that more clear on the Tasks page. The Tasks page has each video listed individually with no reference to the grouping.

Image

Image

holta commented 5 months ago

@avni there's an apostrophe in the title of https://youtu.be/1M22zT_w0o8 ("Switzerland's most clickbaitable hike")

▢️ This causes the thumbnail to fail to display, as reconfirmed by @deldesir, and on LRN2.ORG

▢️ Please try again in a few days with a fresh install β€” when this should very likely be fixed β€” thanks to @chapmanjacobd's hard work!

holta commented 5 months ago

https://youtu.be/1M22zT_w0o8 ("Switzerland's most clickbaitable hike")

ASIDE: Users are of course not thrilled that punctuation (e.g. apostrophes) are silently disappearing from original video titles...

PS the 255-character limit for PATH/FILENAME strings (in certain OS's) constrains us at the moment:

avni commented 5 months ago

ASIDE: Users are of course not thrilled that punctuation (e.g. apostrophes) are silently disappearing from original video titles...

Have you already tried escaping the punctuation? A quick search shows a couple of ways to escape specific characters.

holta commented 5 months ago

Have you already tried escaping the punctuation?

If only! Escaping would add extra characters when a book or video's PATH/FILENAME is already almost 255-characters (common OS limit) is... dangerous. Also, there's an 18-year backstory we need to respect, as much as possible, at least for now:

1) Calibre and Calibre-Web have always modified authors' names and book titles, to become somewhat "safer" (and somewhat more readable) OS folder names.

Naturally some people aren't thrilled about Calibre's compromise/hack/kludge of "dumbing down" author names and book titles for the sake of filesystems, 18 years later (fair criticism in 2024!!) But there's no completely magical solution on the immediate horizon, as outlined in 2020 here: https://www.mobileread.com/forums/showthread.php?t=330290

2) Likewise, as outlined above, yt-dlp and xklb do something extremely similar for videos (i.e. converting every video's eccentric "original" author/title strings into a slightly safer OS PATH/FILENAME !)

Recap: There's no magic wand. As the de facto global standard is to respect /library/calibre-web/AUTHOR/TITLE for now πŸ˜‡

holta commented 5 months ago

@EMG70 would you have time to battle-test a diversity of videos &/or playlists in coming days?

FYI a fresh install of IIAB Calibre-Web is best β€” as these 2 PRs were just merged:

EMG70 commented 5 months ago

Will do . Thanks.

holta commented 5 months ago

Will do . Thanks.

@EMG70's bug report: