iiab / calibre-web

:books: Web app for browsing, reading and downloading eBooks stored in a Calibre database
GNU General Public License v3.0
3 stars 4 forks source link

"Upcoming live" and "Actually live" videos are caught in subsequent downloads [need to clearly explain errors, e.g. in "Tasks" view] #202

Open deldesir opened 3 months ago

deldesir commented 3 months ago

Regression / Known issue (introduced by PR #199)

"Upcoming live" and "Actually live" videos are caught in subsequent downloads as requested videos. They will remain as such until they are available, that means having a duration value.

image

Originally posted by @deldesir in https://github.com/iiab/calibre-web/issues/199#issuecomment-2196814647

holta commented 3 months ago

Regression / Known issue (introduced by PR #199)

"Upcoming live" and "Actually live" videos are caught in subsequent downloads as requested videos. They will remain as such until they are available, that means having a duration value.

According to https://github.com/iiab/calibre-web/pull/199#issuecomment-2196814647 itself:

A new PR should [address] this regression by automatically deleting these videos records from xklb-metadata.db

Thanks! Can this PR be pulled together relatively quickly?

Somewhat related:

deldesir commented 3 months ago

I also think task messages should be adjusted according to https://github.com/iiab/calibre-web/issues/188#issuecomment-2190399720

holta commented 3 months ago

I also think task messages should be adjusted according to #188 (comment)

"Tasks" view definitely sounds like the right place for this now. Please go ahead: (keep things as simple as possible!)

holta commented 3 months ago

@deldesir is PR #194 fully adequate, as merged 9 days ago?

(Or does its code need to be slightly revised — if it too is somewhat related to explaining download mechanics of "ostensibly live" videos to users/operators ?)

deldesir commented 3 months ago

The status messages should be more explicit to let the user know about the type of video being processed, I mean the live_status of the video.