iiab / iiab-admin-console

GUI (Admin Console) to configure IIAB and install content
GNU General Public License v2.0
12 stars 16 forks source link

Admin Console currently needs python3-pip & python3-jinja2 #527

Closed holta closed 1 year ago

holta commented 1 year ago

Question for @tim-moody:

Can Admin Console install these 2 apt package prereqs / dependencies?

For now these 2 installs are taken care of at the end of 9-local-addons/tasks/main.yml here:

- name: "INSTALL python3-pip FOR ADMIN CONSOLE 'cmdsrv : Download speedtest-cli' SEE PR #3494 -- INSTALL python3-jinja2 FOR ADMIN CONSOLE 'js-menu : Post process the downloaded menu defs' SEE PR #3496 -- REMOVE THIS CODE LATER"
  package:
    name:
      - python3-pip
      - python3-jinja2
    state: present
  when: admin_console_install

Background:

jvonau commented 1 year ago

https://github.com/iiab/iiab/pull/3496#issuecomment-1474816619

526

jvonau commented 1 year ago

526 negates the need to use python3-pip directly, installing speedtest into a virtual environment and installs the needed library for adm_lib.py that would of been dragged into the system path prior to using an isolated environment for ansible. The outstanding question around speedtest actually being used remains and the code could just be disabled for the time being. With this merged the need for the 9-local routine can go away and life could continue along without pip.

holta commented 1 year ago

Handled by: