search

iiasa / aneris

Harmonization of Emissions Trajectories for Integrated Assessment Models
Apache License 2.0
4 stars 11 forks source link

Add budget harmonization method #29

Closed coroa closed 4 years ago

coroa commented 4 years ago

~Includes changes from #27.~

~So to focus on new additions, it'd be good to only look at the few last commits.~

The ipopt solver has not been added as an explicit python dependency, since it is relatively heavy and only necessary when one explicitly chooses the budget method. One could add it as python variant, like test or doc, though.

gidden commented 4 years ago

@coroa on this one, could you please rebase to only the commits related? I may have a few comments which would be easier to walk through as such.

coroa commented 4 years ago

@coroa on this one, could you please rebase to only the commits related? I may have a few comments which would be easier to walk through as such.

Done

gidden commented 4 years ago

Regarding IPOPT depedency - I agree that it should be optional (and users should install via conda-forge or similar..). Do you think it's worth doing a check with intelligent error message or let that fall through to pyomo?

coroa commented 4 years ago

@gidden Please check whether the last commits, fulfill your requirements.

gidden commented 4 years ago

Looks great, thanks @coroa !