iiasa / climate-assessment

https://climate-assessment.readthedocs.io/en/latest
MIT License
20 stars 18 forks source link

Update documentation for citations and input file formats #26

Closed jkikstra closed 1 year ago

jkikstra commented 1 year ago

Updates documentation:

Adresses https://github.com/iiasa/climate-assessment/issues/25

jkikstra commented 1 year ago

Looks like a test is failing because of a numpy update;

=========================== short test summary info ============================
FAILED tests/regression/test_workflow.py::test_workflow_ciceroscm - AssertionError: AttributeError("module 'numpy' has no attribute 'float'.
  `np.float` was a deprecated alias for the builtin `float`.
phackstock commented 1 year ago

Looks like a test is failing because of a numpy update;

I guess there's two ways of fixing this, pinning the numpy version or changing np.float to float. I would say the latter is preferred.

jkikstra commented 1 year ago

Looks like a test is failing because of a numpy update;

I guess there's two ways of fixing this, pinning the numpy version or changing np.float to float. I would say the latter is preferred.

Yes - just need to find where it is actually used, will try and go down the rabbit hole

phackstock commented 1 year ago

If you, for now, pin the version at numpy <= 1.19 it should be fine (see the deprecation section of the numpy 1.20 release notes https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations). Once cicero addresses the numpy issue you can remove the version pin.

jkikstra commented 1 year ago

OK.

Have made an issue on openscm-runner; https://github.com/openscm/openscm-runner/issues/81

lewisjared commented 1 year ago

Thanks for the MR and diagnosis. If the current master branch of openscm-runner fixes the tests, I'll make a new release.

jkikstra commented 1 year ago

Okay - thanks @lewisjared!

Let me know when we can/should update the dependency, since it was so far pinned on 0.9.1. Maybe in a separate PR?

lewisjared commented 1 year ago

Sorry I missed this. I just cut a new release so that should be available in the next hour

lewisjared commented 1 year ago

Hitting a few roadblocks regarding test coverage so it might not be resolved today, but I'll fix as soon as I can

https://github.com/openscm/openscm-runner/pull/83

jkikstra commented 1 year ago

Adjusted, and passing tests now.