search

iiasa / climate-assessment

https://climate-assessment.readthedocs.io/en/latest
MIT License
19 stars 18 forks source link

Streamline version string of CLI between emulators (at least FaIR and MAGICC) #39

Open jkikstra opened 1 year ago

jkikstra commented 1 year ago

At the moment it looks like we need to do:

--model "magicc" --version "v7.5.3"

and 

--model "fair" --version "1.6.2"

It's confusing to have "v" for magicc but not for fair.

P.S. note that CICERO has a different version naming entirely: "v2019vCH4"

Line for FAIR: https://github.com/iiasa/climate-assessment/blob/315a4656d2e823501e7ce13e43db3273ee9bc56d/src/climate_assessment/climate/fair.py#L8

Line for MAGICC: https://github.com/iiasa/climate-assessment/blob/315a4656d2e823501e7ce13e43db3273ee9bc56d/src/climate_assessment/climate/magicc7.py#L8

Line for CICERO: https://github.com/iiasa/climate-assessment/blob/315a4656d2e823501e7ce13e43db3273ee9bc56d/src/climate_assessment/climate/ciceroscm.py#L7

(ping @phackstock)

phackstock commented 1 year ago

Thanks @jkikstra, that'll prove really useful in the future.

jkikstra commented 1 year ago

Just an extra note: I think these "DEFAULT_*_VERSION" variables are actually not used in the output data (and so do also not feature in the test-data files), which would make life easier in changing this. One suggestion would we to change all three to "ipcc_ar6" or "ipcc_ar6wg3" or simply "ar6".