search

iiasa / climate-assessment

https://climate-assessment.readthedocs.io/en/latest
MIT License
19 stars 18 forks source link

Turn on CI #4

Closed znicholls closed 2 years ago

znicholls commented 2 years ago

Closes #3

The SR1.5 running tests are removed as they require a MAGICC configuration file that was only used for testing and we don't want to include in the repository because it's not related to reproducing WG3 (it was a sensitivity thing that we no longer need)

znicholls commented 2 years ago

@phackstock we need the scenario explorer secrets added to get this going I think

phackstock commented 2 years ago

@phackstock we need the scenario explorer secrets added to get this going I think

Ah good point, on it.

znicholls commented 2 years ago

I'm attempting to fix the failing harmonisation tests now

phackstock commented 2 years ago

Secrets are set.

phackstock commented 2 years ago

@znicholls looks like there's seven CI runs happening, is that on purpose?

znicholls commented 2 years ago

@znicholls looks like there's seven CI runs happening, is that on purpose?

Seven different checks? Yes, I'm just trying to get everything running before I put nightly and WG3 reproduction back on a schedule

Or do you mean 7 commits running at once? If yes, that's just cause I don't bother cancelling workflows which failed

phackstock commented 2 years ago

@znicholls, I was referring to the seven different checks, but alright I see then it's fine.

znicholls commented 2 years ago

Beauty

On Thu, 9 Jun 2022 at 2:54 pm, Philip Hackstock @.***> wrote:

@.**** approved this pull request.

Looks good to me, ready to be merged.

— Reply to this email directly, view it on GitHub https://github.com/iiasa/climate-assessment/pull/4#pullrequestreview-1001276416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFUH5GZHUYV6WSLADBQ4N43VOHSR5ANCNFSM5YJID6BQ . You are receiving this because you were mentioned.Message ID: @.***>