Closed znicholls closed 4 months ago
@phackstock or @jkikstra can you give me a hand with downloading the infiller database. I think there's been a change in downloading from IIASA and if you can see the fix in 20 minutes that will be much faster than me.
Our current beautiful hack is here: https://github.com/iiasa/climate-assessment/blob/4a7b7710626c7e8b131e9e5ce876c5d4b7235d6b/.github/workflows/wg3.yaml#L47
I suspect there is now a more elegant way to do this...
Progress update (more tomorrow):
@znicholls, is there a reason to restrict python to <3.11?
Added first try for getting infiller database with new ixmp4
@znicholls, is there a reason to restrict python to <3.11?
I was just going for the pin everything approach. I can try loosening if you want (but I don't think that should be needed?).
@znicholls, the reason I was asking is that our processing container currently runs python 3.11. My hope was that with the pin and maybe a fix for the meta issue I could still run the rest of the processing together with climate-assessment in the same environment.
Seems that fetching the infiller db is working again :)
@znicholls, the reason I was asking is that our processing container currently runs python 3.11. My hope was that with the pin and maybe a fix for the meta issue I could still run the rest of the processing together with climate-assessment in the same environment.
Ye cool, I'll switch it to 3.11 then (and if I forget, poke me :) )
Seems that fetching the infiller db is working again :)
Super!!
Alrighty @phackstock @jkikstra all green, ready for review.
@chrisroadmap with this I think adding FaIR to climate processor should only be a matter of adding the config file(s) to the right place and telling @phackstock how to run FaIR correctly.
@phackstock I don't remember how you guys do it. Do you push merge or me once the CI goes green and assuming you have no more comments?
Pins all the requirements. Swaps to poetry at the same time. Decisions to be made:
requirements.txt
in the repo too? At the moment, everything is pinned inpyproject.toml
, but that doesn't pin dependencies of dependencies. We havepoetry.lock
if people want, but maybe havingrequirements.txt
too is an easy thing to do and helpful.~- [ ] Tests added~ ~- [ ] Documentation added~ ~- [ ] Example added (in the documentation, to an existing notebook, or in a new notebook)~
CHANGELOG.rst
added (single line such as:(`#XX <https://github.com/iiasa/climate-assessment/pull/XX>`_) Added feature which does something
)