iiasa / climate-assessment

https://climate-assessment.readthedocs.io/en/latest
MIT License
19 stars 18 forks source link

Pin requirements #55

Closed znicholls closed 4 months ago

znicholls commented 5 months ago

Pins all the requirements. Swaps to poetry at the same time. Decisions to be made:

~- [ ] Tests added~ ~- [ ] Documentation added~ ~- [ ] Example added (in the documentation, to an existing notebook, or in a new notebook)~

znicholls commented 5 months ago

@phackstock or @jkikstra can you give me a hand with downloading the infiller database. I think there's been a change in downloading from IIASA and if you can see the fix in 20 minutes that will be much faster than me.

Our current beautiful hack is here: https://github.com/iiasa/climate-assessment/blob/4a7b7710626c7e8b131e9e5ce876c5d4b7235d6b/.github/workflows/wg3.yaml#L47

I suspect there is now a more elegant way to do this...

znicholls commented 5 months ago

Progress update (more tomorrow):

phackstock commented 5 months ago

@znicholls, is there a reason to restrict python to <3.11?

phackstock commented 5 months ago

Added first try for getting infiller database with new ixmp4

znicholls commented 5 months ago

@znicholls, is there a reason to restrict python to <3.11?

I was just going for the pin everything approach. I can try loosening if you want (but I don't think that should be needed?).

phackstock commented 4 months ago

@znicholls, the reason I was asking is that our processing container currently runs python 3.11. My hope was that with the pin and maybe a fix for the meta issue I could still run the rest of the processing together with climate-assessment in the same environment.

phackstock commented 4 months ago

Seems that fetching the infiller db is working again :)

znicholls commented 4 months ago

@znicholls, the reason I was asking is that our processing container currently runs python 3.11. My hope was that with the pin and maybe a fix for the meta issue I could still run the rest of the processing together with climate-assessment in the same environment.

Ye cool, I'll switch it to 3.11 then (and if I forget, poke me :) )

znicholls commented 4 months ago

Seems that fetching the infiller db is working again :)

Super!!

znicholls commented 4 months ago

Alrighty @phackstock @jkikstra all green, ready for review.

@chrisroadmap with this I think adding FaIR to climate processor should only be a matter of adding the config file(s) to the right place and telling @phackstock how to run FaIR correctly.

znicholls commented 4 months ago

@phackstock I don't remember how you guys do it. Do you push merge or me once the CI goes green and assuming you have no more comments?