Adapt workaround for #494 due to new lxml release

iiasa / ixmp

The ix modeling platform for integrated and cross-cutting scenario analysis

https://docs.messageix.org/ixmp

Apache License 2.0

38 stars 112 forks source link

Adapt workaround for #494 due to new lxml release #503

Closed glatterf42 closed 11 months ago

glatterf42 commented 11 months ago

LXML has published a new release yesterday, which includes wheels for python 3.8 again. Unfortunately, there is only one wheel for python 3.8 and macos, which specifies macos version 11. Our GHA uses version 12.6, so we still can't get the lxml wheel from pypi for this workflow. This PR makes the workaround workflow step more specific and only executes it on macos.

How to review

Read the diff and note that the CI checks all pass.

PR checklist

[x] Continuous integration checks all ✅
[x] Update tests ✅
~[ ] Add, expand, or update documentation.~ Just CI
~[ ] Update release notes.~ Just CI

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6cab755) 98.8% compared to head (84d01b3) 98.8%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #503 +/- ## ===================================== Coverage 98.8% 98.8% ===================================== Files 44 44 Lines 4747 4747 ===================================== Hits 4694 4694 Misses 53 53 ```