Our whole CI is failing (same for several downstream projects) because one of the pytest hooks here is using a deprecated argument: startdir has been replaced by start_path. This was kindly pointed out in https://github.com/pytest-dev/pytest/issues/12061, though I have to admit even with the linked deprecation changelog, this might not have been entirely clear to me. After all, the changelog says the hook is now receiving 'additional arguments', not 'changed arguments'. Either way, this PR includes the fix.
Should we update the release notes since other projects might have seen failures due to the hook arguments being out of date? If so, we haven't received an issue yet.
How to review
Read the diff and note that the CI checks all pass.
PR checklist
[x] Continuous integration checks all ✅
~[ ] Add or expand tests; coverage checks both ✅~ Just an internal change
~[ ] Add, expand, or update documentation.~ Just an internal change
~[ ] Update release notes.~ Just an internal change
Our whole CI is failing (same for several downstream projects) because one of the pytest hooks here is using a deprecated argument:
startdir
has been replaced bystart_path
. This was kindly pointed out in https://github.com/pytest-dev/pytest/issues/12061, though I have to admit even with the linked deprecation changelog, this might not have been entirely clear to me. After all, the changelog says the hook is now receiving 'additional arguments', not 'changed arguments'. Either way, this PR includes the fix.Should we update the release notes since other projects might have seen failures due to the hook arguments being out of date? If so, we haven't received an issue yet.
How to review
PR checklist