iiasa / ixmp

The ix modeling platform for integrated and cross-cutting scenario analysis
https://docs.messageix.org/ixmp
Apache License 2.0
36 stars 110 forks source link

Limit CI runtime on Windows runners #520

Closed glatterf42 closed 4 months ago

glatterf42 commented 4 months ago

Currently, our CI is "failing" because the codecov-action gets stuck for Windows runners despite the last line showing info - 2024-03-07 05:18:14,167 -- Process Upload complete. It seems this success is not correctly registered so that the workflow doesn't move to the next job. See also

At the moment, this PR simply applies a time limit to this CI step (1 minute should be plenty for a step that usually takes ~5s), but the step will then still fail. So we might want to explore other options such as downgrading to codecov-action@v3. Another option would probably be to run codecov as a command line tool manually.

How to review

Please check the added comment is enough to understand how/when to remove this temporary addition. The CI is not expected to pass on Windows runners.

PR checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.9%. Comparing base (809e28a) to head (6570925).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #520 +/- ## ===================================== Coverage 98.9% 98.9% ===================================== Files 44 44 Lines 4795 4795 ===================================== Hits 4743 4743 Misses 52 52 ```
khaeru commented 4 months ago

At the moment, this PR simply applies a time limit to this CI step (1 minute should be plenty for a step that usually takes ~5s), but the step will then still fail. So we might want to explore other options…

Can you please experiment with adding:

continue-on-error: true

…to only the one step you've modified? I think this should allow the overall jobs to succeed.

glatterf42 commented 4 months ago

Seems to work :)