Closed glatterf42 closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.9%. Comparing base (
809e28a
) to head (6570925
).
At the moment, this PR simply applies a time limit to this CI step (1 minute should be plenty for a step that usually takes ~5s), but the step will then still fail. So we might want to explore other options…
Can you please experiment with adding:
continue-on-error: true
…to only the one step you've modified? I think this should allow the overall jobs to succeed.
Seems to work :)
Currently, our CI is "failing" because the codecov-action gets stuck for Windows runners despite the last line showing
info - 2024-03-07 05:18:14,167 -- Process Upload complete
. It seems this success is not correctly registered so that the workflow doesn't move to the next job. See alsoAt the moment, this PR simply applies a time limit to this CI step (1 minute should be plenty for a step that usually takes ~5s), but the step will then still fail. So we might want to explore other options such as downgrading to codecov-action@v3. Another option would probably be to run codecov as a command line tool manually.
How to review
Please check the added comment is enough to understand how/when to remove this temporary addition. The CI is not expected to pass on Windows runners.
PR checklist