iiasa / ixmp

The ix modeling platform for integrated and cross-cutting scenario analysis
https://docs.messageix.org/ixmp
Apache License 2.0
38 stars 112 forks source link

Use "macos-13" runner label in "pytest" workflow #527

Closed khaeru closed 7 months ago

khaeru commented 7 months ago

@glatterf42 noticed today that CI jobs were failing:

…and traced this to a change in the standard GitHub Actions runners.

This PR switches to macos-13 for these workflows. NB I also had to change the branch protection rule for main to replace macos-latest-py3.12 as a required check with macos-13-py3.12.

How to review

Note that the CI checks all pass.

PR checklist

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.9%. Comparing base (707353e) to head (1945ad0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #527 +/- ## ===================================== Coverage 98.9% 98.9% ===================================== Files 44 44 Lines 4804 4804 ===================================== Hits 4754 4754 Misses 50 50 ```
khaeru commented 7 months ago

I left a longer discussion above so we can just cite this issue in PRs for the other two repos. Could you please open those?

At some point, we should open a PR (and maybe re-open #473) that updates the install instructions document a minimal work-around, maybe in the “Troubleshooting” section, for users who encounter that issue. As you noted, there are likely to be more in the future. We could then link to that work-around from the other install docs on the stack.

glatterf42 commented 7 months ago

The message_ix "Install from conda-forge" workflow succeeds with macos-latest, so maybe this offers hints at a solution, too.