Closed khaeru closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.7%. Comparing base (
f08447f
) to head (97d9f30
).:exclamation: Current head 97d9f30 differs from pull request most recent head 1d40c22
Please upload reports for the commit 1d40c22 to get more accurate results.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.8%. Comparing base (
cf56d03
) to head (caaaa3d
). Report is 41 commits behind head on main.
@glatterf42 let me know whether you think there is urgency to include this in the 3.9 release.
We would need to invite and wait for reviews from:
Given this might take a few days, and the first three are probably capable to use it from main
in the period between the 3.9 and 3.10 releases, I would lean to "no". OTOH, if we have users in the upcoming workshop who have macOS arm64 machines, this might (not necessarily) save some support overhead.
If we wait, then I will also wait until after the workshop to request a review of iiasa/actions#13.
I'd also say it's likely not urgent. Workshop users will learn about GitHub anyway and if they need to use this branch, this will be a good opportunity to practice. They could also then provide feedback about their install process. However, I think we can already invite review from our team members and if these come in very soon, we can maybe still include this in 3.9 :)
@ravitby @SiddharthJoshi-Git @setupelz —could you please try the steps above under "How to review" / "message_ix usage" and let us know the results?
@phackstock —could you please comment on the questions above under "How to review" / "Scenario Explorer usage"?
Great, thanks for confirming.
@glatterf42, since the other requested colleagues seem unable to review this over the past ~6 weeks, I propose we merge and wait for feedback that may come as they/others use it from main
. If we don't get positive confirmation before we start prep for the next release, then we can ask again.
This PR responds to #531.
Improve
.backend.jdbc
:-Djava.library.path=…
when starting the JVM, giving two directories containing the required binary libraries (with the extension.so
on Linux;.dll
on Windows; and.dylib
on macOS):The second directory is redundant if the first one is present (i.e. if a GAMS installation exists). To confirm this, the PR currently deletes the bundled libraries entirely. These commits could also be dropped instead.
How to review
message_ix
usage: Installixmp
from this branch on a macOS arm64 system with an arm64 version of Python. Run the test suite or other code and confirm the code functions as expected.message_ix
deployments; particularly, for the Scenario Explorer. Is GAMS installed in these contexts? Will the absence of the .dylib, .so, and/or .dll files bundled with the ixmp Python package affect these deployments?PR checklist