iiasa / ixmp

The ix modeling platform for integrated and cross-cutting scenario analysis
https://docs.messageix.org/ixmp
Apache License 2.0
38 stars 112 forks source link

Support arm64 architecture on macOS #532

Closed khaeru closed 4 months ago

khaeru commented 6 months ago

This PR responds to #531.

How to review

PR checklist

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.7%. Comparing base (f08447f) to head (97d9f30).

:exclamation: Current head 97d9f30 differs from pull request most recent head 1d40c22

Please upload reports for the commit 1d40c22 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #532 +/- ## ======================================= - Coverage 98.8% 98.7% -0.1% ======================================= Files 44 44 Lines 4804 4803 -1 ======================================= - Hits 4747 4744 -3 - Misses 57 59 +2 ``` | [Files](https://app.codecov.io/gh/iiasa/ixmp/pull/532?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa) | Coverage Δ | | |---|---|---| | [ixmp/backend/jdbc.py](https://app.codecov.io/gh/iiasa/ixmp/pull/532?src=pr&el=tree&filepath=ixmp%2Fbackend%2Fjdbc.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa#diff-aXhtcC9iYWNrZW5kL2pkYmMucHk=) | `97.2% <100.0%> (-0.2%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/iiasa/ixmp/pull/532/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa)
codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.8%. Comparing base (cf56d03) to head (caaaa3d). Report is 41 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #532 +/- ## ===================================== Coverage 98.8% 98.8% ===================================== Files 44 44 Lines 4796 4813 +17 ===================================== + Hits 4739 4756 +17 Misses 57 57 ``` | [Files with missing lines](https://app.codecov.io/gh/iiasa/ixmp/pull/532?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa) | Coverage Δ | | |---|---|---| | [ixmp/backend/jdbc.py](https://app.codecov.io/gh/iiasa/ixmp/pull/532?src=pr&el=tree&filepath=ixmp%2Fbackend%2Fjdbc.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa#diff-aXhtcC9iYWNrZW5kL2pkYmMucHk=) | `97.4% <100.0%> (+<0.1%)` | :arrow_up: | | [ixmp/model/gams.py](https://app.codecov.io/gh/iiasa/ixmp/pull/532?src=pr&el=tree&filepath=ixmp%2Fmodel%2Fgams.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa#diff-aXhtcC9tb2RlbC9nYW1zLnB5) | `96.2% <100.0%> (+0.3%)` | :arrow_up: |
khaeru commented 6 months ago

@glatterf42 let me know whether you think there is urgency to include this in the 3.9 release.

We would need to invite and wait for reviews from:

Given this might take a few days, and the first three are probably capable to use it from main in the period between the 3.9 and 3.10 releases, I would lean to "no". OTOH, if we have users in the upcoming workshop who have macOS arm64 machines, this might (not necessarily) save some support overhead.

If we wait, then I will also wait until after the workshop to request a review of iiasa/actions#13.

glatterf42 commented 6 months ago

I'd also say it's likely not urgent. Workshop users will learn about GitHub anyway and if they need to use this branch, this will be a good opportunity to practice. They could also then provide feedback about their install process. However, I think we can already invite review from our team members and if these come in very soon, we can maybe still include this in 3.9 :)

khaeru commented 6 months ago

@ravitby @SiddharthJoshi-Git @setupelz —could you please try the steps above under "How to review" / "message_ix usage" and let us know the results?

@phackstock —could you please comment on the questions above under "How to review" / "Scenario Explorer usage"?

khaeru commented 6 months ago

Great, thanks for confirming.

khaeru commented 4 months ago

@glatterf42, since the other requested colleagues seem unable to review this over the past ~6 weeks, I propose we merge and wait for feedback that may come as they/others use it from main. If we don't get positive confirmation before we start prep for the next release, then we can ask again.