Closed khaeru closed 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.9%. Comparing base (
02c887a
) to head (dcf15af
). Report is 14 commits behind head on main.
🚨 Try these New Features:
There doesn't appear to be any upstream response in the last 2+ months. One possibility is we switch away from this to an alternative that seems to be maintained. Alternatives I'm aware of include:
requests-mock
—I have used this myself in other projects, but per jamielennox/requests-mock#262 / pypi/support/issues/4625 it may not be actively maintained.pytest-httpserver
—I have not used this, but it shows signs of being actively maintained.mimicker
—Recently updated, but only 35 commits and fewer contributors.IIRC pretenders is also a source of flakiness, so a switch could side-step those issues.
pytest-httpserver
—I have not used this, but it shows signs of being actively maintained.
Okay, that was pretty easily done and the tests where it was used are simplified.
Thanks, great news! Especially since the one failed test just failed due to a segfault, so this PR might be complete :)
Python 3.13 will be released 2024-10-01. This PR is to:
ixmp
is compatible with the new version. This includes the existence of compatible releases of upstream dependencies. If those releases are not immediately available, the PR can aid to monitor and track upstream issues:list[str]
instead offrom typing import List
/List[str]
.from collections.abc import Sequence
et al instead of deprecatedfrom typing import Sequence
.These changes would then be on
main
and ready for the next release at any time.How to review
PR checklist