Closed khaeru closed 1 year ago
FYI also @glatterf42.
Thanks Paul, looks good to me! We can merge this to the main branch, but we will need to check later how to merge with the new developments we are working on.
If you have started branches from some commit at main before this PR was merged, you may now need to reconcile these branches with the latest changes. You could rebase your branches on to the new state of main or you merge the changes of main into your branches - this is mostly up to you. Merging will create an additional commit, while rebasing will keep the commit history linear (so the history of the repo is easier to understand). If you don't feel comfortable rebasing your branches, please just let me know :)
As discussed on Friday 02 June.
In addition, I:
2
4
How to review
@Zh-xy @amastrucci I ask for approving reviews from each of you to confirm that you:
Please ask any questions if the above are not clear or you need further information.