search

iiasa / message-ix-buildings

Apache License 2.0
2 stars 3 forks source link

CHILLED code needs to be cleaned up #22

Open measrainsey opened 3 months ago

measrainsey commented 3 months ago

As pointed out by @glatterf42 in https://github.com/iiasa/message-ix-buildings/pull/18#pullrequestreview-2199797510, the CHILLED code would benefit from the following upgrades:

Code could still be cleaned up (e.g. by adding mypy and ruff like we have them in message_ix and addressing linting/formatting errors or by cleaning up comments and type: ignore statements), but this could also happen in a later PR. If saved for later, please open an issue to not forget about this.

This issue is meant to track this work that needs to be done.

measrainsey commented 2 months ago

Making a note that I should really reconfigure the message_ix_buildings.chilled.core.climate.create_climate_variables_maps function because right now the complexity of that function is 39.