Closed glatterf42 closed 8 months ago
Edit: the ScenarioInfo.scenario_obj
field had the kw_only
argument, too, and I left it in at first because I thought it wouldn't hurt to keep it for the future (since it was set to its default False
value. But python < 3.10 might still complain about not knowing this argument, so I commented it out as well.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
af092b1
) 74.9% compared to head (cbf7b71
) 74.9%.
Edit: the
ScenarioInfo.scenario_obj
field had thekw_only
argument, too, and I left it in at first because I thought it wouldn't hurt to keep it for the future (since it was set to its defaultFalse
value. But python < 3.10 might still complain about not knowing this argument, so I commented it out as well.
Thanks @glatterf42. Indeed, that instance needs to be commented/removed too.
Thanks for confirming. I think the codecov failure is due to the two pushes to this branch being in quick succession, this sometimes leads to coverage reports being not properly collected. The apparently uncovered lines are in a file I didn't touch, at least.
Thanks, that would have defeated the purpose of this PR.
I'd leave the expansion of the docs for another PR to avoid scope creep.
As discovered by @behnam-zakeri, our current code should either require python >= 3.10, or remove the
dataclass()
argumentkw_only
until this is the case. Should we leave a note somewhere that we strongly encourage users to still use the syntax you were trying to enforce, @khaeru?Please note: this PR leaves a TODO comment to come back to it. The other changes are small notes that mypy complained about.
How to review
PR checklist