search

iiasa / message-ix-models

Tools for the MESSAGEix-GLOBIOM family of models
https://docs.messageix.org/models
Apache License 2.0
16 stars 31 forks source link

Change the default final year in `tools.costs` to 2110 #190

Closed measrainsey closed 1 month ago

measrainsey commented 1 month ago

Update costs module to include 2110 in output by default

Currently the default final_year in tools.costs is 2100, which does not pair well with MESSAGEix's final year usally being 2110. Currently, users can change the final_year themselves as a parameter when creating their Config file, but given the use-base of this tool is mostly our internal team, I'm changing the default final_year to 2110.

Note that this does not mean costs are projected to 2110 now -- costs are still only projected to 2100. The module copies over 2100 projected costs for all years after 2100.

Also note that this PR is currently pointing to #187 -- I was thinking it would be best to wait for that PR to be merged first, then point this PR to main. But happy to revise as necessary.

Branch now has been rebased and points to main.

How to review

For @khaeru and/or @glatterf42 : Read the diff and note that the CI checks all pass.

PR checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.7%. Comparing base (5b3a1f8) to head (8fa534b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #190 +/- ## ===================================== Coverage 76.7% 76.7% ===================================== Files 112 112 Lines 7154 7154 ===================================== Hits 5491 5491 Misses 1663 1663 ``` | [Files](https://app.codecov.io/gh/iiasa/message-ix-models/pull/190?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa) | Coverage Δ | | |---|---|---| | [message\_ix\_models/tools/costs/config.py](https://app.codecov.io/gh/iiasa/message-ix-models/pull/190?src=pr&el=tree&filepath=message_ix_models%2Ftools%2Fcosts%2Fconfig.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa#diff-bWVzc2FnZV9peF9tb2RlbHMvdG9vbHMvY29zdHMvY29uZmlnLnB5) | `97.2% <100.0%> (ø)` | | | [message\_ix\_models/tools/costs/projections.py](https://app.codecov.io/gh/iiasa/message-ix-models/pull/190?src=pr&el=tree&filepath=message_ix_models%2Ftools%2Fcosts%2Fprojections.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa#diff-bWVzc2FnZV9peF9tb2RlbHMvdG9vbHMvY29zdHMvcHJvamVjdGlvbnMucHk=) | `84.7% <ø> (ø)` | |