iiasa / message-ix-models

Tools for the MESSAGEix-GLOBIOM family of models
https://docs.messageix.org/models
Apache License 2.0
17 stars 33 forks source link

Collect pieces for SSP 2024/ScenarioMIP workflows #234

Open khaeru opened 1 week ago

khaeru commented 1 week ago

As discussed at today's MESSAGE team meeting.

We want to, at some point, bring together all the improvements and new code used in the SSP/ScenarioMIP workflows. This issue is to:

  1. Identify what and where those pieces are, how they are used (in what order), etc.
  2. Decide where they should eventually ‘land’ within message-ix-models or other repos.
  3. Track as they are associated with PRs, either:
    • If atomic and separable, directly into main, or
    • If they need extensive clean-up that is not yet scheduled, into a ssp-dev branch: #235.

Pieces

General/other

Direct air capture (DAC)

Materials

Techno-economic parameters (@measrainsey)

Water/nexus

Things to do

adrivinca commented 1 week ago

Thanks for this, I started a branch wat_SSP_upd1 that takes a bit from the older water_SSP_update (soon obsolete) but that is meant to be for few incremental fixes, including tests when possible

khaeru commented 1 week ago

@adrivinca I updated the description to replace “Another small change by @adrivinca that will be included in a small PR” with #236 —assuming that's the thing you referred to on Thursday. Please correct if I'm wrong there.

measrainsey commented 1 week ago

Hi! Thank you for documenting this process.

I have a question: I have a few scripts (that are currently on a personal repo) that have my workflow of the modifications I made to certain scenarios for the ScenarioMIP submission. Nothing complicated, just small changes to diffusion constraints and share constraints in the transport, residential + commercial, and industry sectors. I imagine it would be best to migrate these scripts to a team-accessible location.

Where would be the best place to move my scripts over? Should they be housed here on message-ix-models (for example, in message_ix_models.project.ssp)?

khaeru commented 1 week ago

@measrainsey yes, that would be wonderful, thank you!

I would suggest:

  1. Create a branch like ssp-dev/mm or similar.
  2. Create a directory like message_ix_models/project/ssp/script/.
  3. Commit files (warts and all, no clean-up needed) into that directory.
  4. Open a draft PR into the branch ssp-dev associated with #235.

Once others to do the same, we can check for discrepancies, and figure out an appropriate way to bring the pieces together.