iiasa / message-ix-models

Tools for the MESSAGEix-GLOBIOM family of models
https://docs.messageix.org/models
Apache License 2.0
17 stars 34 forks source link

Replace resolved numpy workaround with dask workaround #245

Closed glatterf42 closed 1 week ago

glatterf42 commented 1 week ago

This is a twin of https://github.com/iiasa/message_ix/pull/887, fixing the CI test suite by pinning dask until genno is compatible with the latest versions of it.

PR checklist

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.5%. Comparing base (0645fd5) to head (a71d060). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #245 +/- ## ======================================= - Coverage 76.5% 75.5% -1.0% ======================================= Files 203 203 Lines 15546 15546 ======================================= - Hits 11896 11748 -148 - Misses 3650 3798 +148 ``` | [Files with missing lines](https://app.codecov.io/gh/iiasa/message-ix-models/pull/245?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa) | Coverage Δ | | |---|---|---| | [message\_ix\_models/model/water/data/demands.py](https://app.codecov.io/gh/iiasa/message-ix-models/pull/245?src=pr&el=tree&filepath=message_ix_models%2Fmodel%2Fwater%2Fdata%2Fdemands.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa#diff-bWVzc2FnZV9peF9tb2RlbHMvbW9kZWwvd2F0ZXIvZGF0YS9kZW1hbmRzLnB5) | `78.4% <100.0%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/iiasa/message-ix-models/pull/245/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa)
khaeru commented 1 week ago

@glatterf42 any idea why we're seeing two instances of each of the Codecov checks?

glatterf42 commented 1 week ago

Not really. I think I did a git commit --fixup and rebase locally while the tests started running and force pushed it immediately, so maybe that confused the GitHub runners. If that's the case, we should not see it anymore :)