iiasa / message-ix-models

Tools for the MESSAGEix-GLOBIOM family of models

https://docs.messageix.org/models

Apache License 2.0

17 stars 34 forks source link

Further work around iiasa/ixmp#425 #55

Closed khaeru closed 2 years ago

khaeru commented 2 years ago

Addresses #45, specifically https://github.com/iiasa/message-ix-models/issues/45#issuecomment-1058107571 and https://github.com/iiasa/message-ix-models/issues/45#issuecomment-1059039078

FYI @Jihoon @volker-krey

How to review

Try the code against an Oracle database, e.g. ixmp-dev, and confirm no exception is raised when adding disutility data to a Scenario stored on a JDBCBackend/Oracle database.
Time: 20–30 minutes.

PR checklist

[x] Continuous integration checks all ✅
[x] Add or expand tests; coverage checks both ✅
[x] Add, expand, or update documentation.
[x] Update doc/whatsnew.

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (9adf332) into main (bd71aa6) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         1724      1726    +2     
=========================================
+ Hits          1724      1726    +2

Impacted Files	Coverage Δ
...ge-ix-models/message_ix_models/model/disutility.py	`100.00% <0.00%> (ø)`
...s/message_ix_models/tests/model/test_disutility.py	`100.00% <0.00%> (ø)`

volker-krey commented 2 years ago

Process runs smoothly on Oracle backend ixmp_dev.

khaeru commented 2 years ago

Thanks for testing! FWIW, we try to have an approving review before merging PRs, so please do leave one and remove other reviewer(s) if their review is no longer needed.