Closed glatterf42 closed 1 year ago
Merging #97 (4567499) into main (3ded82f) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 58 58
Lines 4009 4009
=======================================
Hits 2690 2690
Misses 1319 1319
Impacted Files | Coverage Δ | |
---|---|---|
message_ix_models/tests/test_util.py | 100.00% <100.00%> (ø) |
Changed in pint 0.21: atol in numpy.isclose() now requires units to be specified, see e.g. their commit that resolved their tests issues introduced by this change.
hgrecco/pint/issues/1277 might also occur somewhere in our code as workarounds that we can now possibly remove.
Adding a unit to
atol
intests/test_util.py
'stest_convert_units()
. Do we usenumpy.isclose()
ornumpy.allclose()
with units anywhere else? Does the new behaviour need documentation for our users?How to review
PR checklist