iiasa / message_doc

MESSAGEix-GLOBIOM documentation
https://docs.messageix.org/global/
8 stars 18 forks source link

Suggested changes for sections: energy demand & tech change #31

Closed Jihoon closed 5 years ago

Jihoon commented 5 years ago

Minor edits and improvements

In technological change section, it would be helpful to add remarks on how general diffusion constraints are determined for different technologies or what the values are based on.

Jihoon commented 5 years ago

For 'Energy demand':

jkikstra commented 5 years ago

@Jihoon I was assigned to check up on this PR. A few comments:

I very much like the textual changes in the documentation, it is much clearer now.

Things that should be changed:

  1. I believe that these changes should first be committed to #20 (https://github.com/iiasa/message_doc/tree/2019-update) rather than directly to the master.

Minor textual points that could be considered:

  1. Rather write "quantity" than "variable", to be fully generic in the description of the tables.

  2. A space is missing after *t* for t=0 at the line "Fig. 13 below illustrates the maximum technology growth starting at a level of 1 in year t=0 for ... "

As there is no-one besides yourself assigned to review these changes (see assigned reviewers), it's up to you to decide whether someone else should still look at this before committing to the 2019-update (#20) branch.

Jihoon commented 5 years ago

replaced with #34