iiasa / message_ix

The integrated assessment and energy systems model MESSAGEix
https://docs.messageix.org
Apache License 2.0
112 stars 149 forks source link

OPERATING_RESERVE_CONSTRAINT equation missing in GAMS #61

Open ClaraLuisa opened 6 years ago

ClaraLuisa commented 6 years ago

Hey there, @tzipperle and I noticed that the equation OPERATING_RESERVE_CONSTRAINT is missing in the GAMS model_core and that the flexibility_factor does not show up in any other equation. Is this on purpose or is this a bug?

gidden commented 6 years ago

Hey @ClaraLuisa, my understanding is that the renewables implementation is being revised at present (I am not sure why the constraint was removed). Perhaps @adrivinca or @volker-krey can chime in?

ClaraLuisa commented 6 years ago

Hey @gidden thanks for the quick reply. I heard that the renewable section will be revised, however with the OPERATING_RESERVE_CONSTRAINT it seems like the equation simply went missing by accident (it is still there in the message_ix legacy repository) as the title is still there and also the description.

adrivinca commented 6 years ago

Hi, @danielhuppmann deliberately did not copy the equation in message_ix. The reason is that in the old implementation there were also different values of the flexibility factor depending on the rating (it was the relation oper_res in relation_activity). We therefore introduced the 'rating' dimension for flexibility factor in the GAMS code, but then the equation should be redesigned, we were thinking by adding a variable ACTIVITY_FLEX(......,rating). Also it seems that the inequality formulation would not fit our purposes anymore, because it does not guarantee that the model chooses the most reliable bins at first, so an additional equation would be required. But we are still thinking about it.

ClaraLuisa commented 6 years ago

Hi @adrivinca, thanks for clarifying. This sounds like an intersting task indeed. Is there already a scedule on when about this redesign is going to happen?

adrivinca commented 6 years ago

Hi, so the idea to complete it at the hackaton, I will not be there though, so I will try to bring it forward and facilitate the remaining steps for you and who else will work on it. First of all we can move the conversation to existing issues in message_ix_dev this explains the issue: https://github.com/iiasa/message_ix_dev/issues/22 we need a tutorial, or simple example to test the equations https://github.com/iiasa/message_ix_dev/issues/23 https://github.com/iiasa/message_ix_dev/issues/21

but I have created on, can be see in my forked repository (sorry for this shifting from ix and ix_dev repos) https://github.com/adrivinca/message_ix/tree/RES_impl_tutorial