Closed glatterf42 closed 1 year ago
@khaeru Do you think we should mention not installing jpype version 1.4.1 in the installation instructions? I was thinking of adding that to the 'known issues', but then I saw that you removed the temporary workaround in iiasa/ixmp#463, so I don't know if this is still relevant?
Merging #720 (1b97c02) into main (6dee23a) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #720 +/- ##
=====================================
Coverage 94.4% 94.4%
=====================================
Files 43 43
Lines 3448 3448
=====================================
Hits 3257 3257
Misses 191 191
@khaeru Do you think we should mention not installing jpype version 1.4.1 in the installation instructions? I was thinking of adding that to the 'known issues', but then I saw that you removed the temporary workaround in iiasa/ixmp#463, so I don't know if this is still relevant?
It appears to have resolved itself. Both the ixmp and message-ix "pytest" CI workflows appear to be using JPype1 v1.4.1, and test_del_ts is passing. We don't have a concrete understanding of what was causing the issue: we only know that it appeared around the time JPype1 v1.4.1 appeared.
tl;dr—I'd agree with your judgement that we don't need to specifically mention it in the install instructions.
Thanks @glatterf42! 🚀
Closes #698 and #718. According to the notes I gathered during recent installation/CI runs, this PR
upstream
and fetches the tags from thereHow to review
PR checklist
macos-latest-py3.7
per iiasa/ixmp#484.