iiasa / message_ix

The integrated assessment and energy systems model MESSAGEix
https://docs.messageix.org
Apache License 2.0
111 stars 149 forks source link

Add dac #793

Closed ywpratama closed 3 months ago

ywpratama commented 4 months ago

Required: write a single sentence that describes the changes made by this PR.

How to review

Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal. If no review is required, write “No review:” and describe why.

PR checklist

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 184 lines in your changes are missing coverage. Please review.

Project coverage is 91.6%. Comparing base (31d9c58) to head (464a0a3). Report is 203 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #793 +/- ## ======================================= - Coverage 94.3% 91.6% -2.8% ======================================= Files 43 46 +3 Lines 3475 4513 +1038 ======================================= + Hits 3280 4137 +857 - Misses 195 376 +181 ``` | [Files](https://app.codecov.io/gh/iiasa/message_ix/pull/793?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa) | Coverage Δ | | |---|---|---| | [message\_ix/tools/add\_dac/\_\_init\_\_.py](https://app.codecov.io/gh/iiasa/message_ix/pull/793?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa#diff-bWVzc2FnZV9peC90b29scy9hZGRfZGFjL19faW5pdF9fLnB5) | `0.0% <0.0%> (ø)` | | ... and [39 files with indirect coverage changes](https://app.codecov.io/gh/iiasa/message_ix/pull/793/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa)
glatterf42 commented 4 months ago

Hi @ywpratama, just so you know: tutorial failures might not be caused by your new code here. There was a bug introduced with a recent version of plotnine. To remedy, you could e.g. replicate https://github.com/iiasa/message_ix/pull/784/commits/c796cc5ba154bade747f89f2926974eb40771e72. This is, however, only a temporary fix and if you don't mind the tutorials failing for now, some new version will probably fix the bug in the not-too-far future.

Same goes for individual tests that really look like they should be passing. We are currently trying to fix this flakiness in https://github.com/iiasa/message_ix/pull/784.

gidden commented 3 months ago

closing in favor of #807