Closed khaeru closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.4%. Comparing base (
e33ae53
) to head (f4cbe57
).
Do you want to fix them here or should this be a new PR?
I think these should perhaps be PRs upstream. This is basically what we tried to solve in khaeru/genno#94 and khaeru/genno#108, and I now have a different idea of how to resolve these issues.
Previously (those above PRs) we tried to use the intersphinx_mapping
to force lookups to resolve correctly. I don't know if this does/can work.
Instead, I think we can change some references like this: https://github.com/iiasa/ixmp/blob/5713fc14c0206c664405e4dd59576808b65832b9/ixmp/core/timeseries.py#L326 to this:
… :meth:`.Platform.add_timeslice`
Why should that hopefully work?
genno.compat.sphinx.rewrite_refs
extension, gets rewritten to "ixmp.Platform.add_timeslice", and this full ref is found exactly in the intersphinx inventory.This will be a little awkward because we basically will need to:
…however, I think would be pretty quick to do in a couple of follow-up PRs. Also not very urgent; can be done closer to the next release.
How to review
Read the diff and note that the CI checks all pass.
PR checklist