Open gidden opened 3 months ago
Attention: Patch coverage is 0.58480%
with 170 lines
in your changes are missing coverage. Please review.
Project coverage is 91.8%. Comparing base (
27cd54e
) to head (96c5cd1
).:exclamation: Current head 96c5cd1 differs from pull request most recent head 67181b2. Consider uploading reports for the commit 67181b2 to get more accurate results
Hi @gidden, please clarify for me: I thought we wanted to have the tutorials be part of message-ix-models. Was this decision revised? Should I still set up a docs page etc for tutorials in message-ix-models?
Hey @glatterf42 - good questions. Yes, in reviewing this PR and related work with @ywpratama yesterday, we realized that his add_dac()
functionality was more generic and could be applied at a high level repo (similar to add_years()
here). That is at least the proposal for now, which we can discuss once the PR is finalized.
So in short, no need to add tutorials page yet to message-ix-models
@glatterf42 and @ywpratama - this PR now has the content added to it that is expected. It would be useful if the two of you could sit down and discuss how to best add relevant tests for this so it can be merged.
@ywpratama there should be already available documentation for how to pass the code quality checks
This is a fresh PR where we will implement DACCS related tutorials. It depends on https://github.com/iiasa/message-ix-models/pull/158 where additional features for implementing DACCS in scenarios are developed.
This supercedes #793 and #806
FYI @ywpratama
Required: write a single sentence that describes the changes made by this PR.
How to review
Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal. If no review is required, write “No review:” and describe why.
PR checklist
[ ] Continuous integration checks all ✅
[ ] Update release notes.