Closed behnam-zakeri closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.6%. Comparing base (
0cc8102
) to head (fde7729
). Report is 7 commits behind head on main.
Thanks @glatterf42 for the quick review. I hadn't changed the objective functions in those test because we need to add investment cost for the grid (one of the ToDos) which will change the objective function. I discussed with @OFR-IIASA this morning, and we believe it's not needed to update the investment cost of wind and coal power plants (the optional ToDo), because this tutorial is not representing the reality of today, or in fact any period in history, and just wants to showcase how the model works with two technologies with different investment cost. As such, I will leave the investment cost for wind and coal power plants as it is for the time being.
Highjacking this PR to enable ruff for all tutorial files since I started migrating to make_df
and was annoyed by the code not following our code style.
As for the question I raised earlier, I have now concluded from your PR description, @behnam-zakeri, that all issues except #814 are indeed closed by this PR since #814 is the only one where you say "partially addressing". Assuming this is true, once we get the tests to pass, this PR is good to go :)
Thanks @glatterf42 for the kind reminder and sorry for the delay. This PR indeed closes the issues https://github.com/iiasa/message_ix/issues/525, https://github.com/iiasa/message_ix/issues/609, https://github.com/iiasa/message_ix/issues/813, and https://github.com/iiasa/message_ix/issues/814. I correct the description to show that this resolves #814 fully and not partially.
This PR resolves issues related to Westeros "baseline" tutorial, including #525, #609, #813, and #814. This PR does the following:
technical_lifetime
of that technology (addressing #525)How to review
PR checklist