Closed glatterf42 closed 4 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.6%. Comparing base (
bdf5747
) to head (6c5bc91
).
As mentioned by @adrivinca just now, we want to make sure that the quick-install pip steps include information about java. Either explicitly calling out the assumption that it's installed or saying how it can be installed.
I pushed some commits based on the following observations/ideas:
Are there any commits missing from this PR? Because your comment states that you want to move the "Install from GitHub" section from quick to full install, but it is still visible in the quick install section of the recent RTD build for this PR.
Also, there seem to be two notes in the RTD build output related to the latest changes:
/home/docs/checkouts/readthedocs.org/user_builds/iiasa-energy-program-message-ix/checkouts/843/doc/install-full.rst:41: WARNING: py:class reference target not found: JDBCBackend
/home/docs/checkouts/readthedocs.org/user_builds/iiasa-energy-program-message-ix/checkouts/843/doc/prereqs.rst:84: WARNING: undefined label: 'install-full'
thanks both for the great work. just a comment after reviewing the installation docs
Overall I think it looks good. I was a bit confused by this "quick" and "full" distinction, which gives the impression that if you do the quick install you don't have a full version of message_ix I would rename the "full" to "advanced", like in several software installation processes. The difference between the two installations seems simply that "full" is more advanced in terms of personalizing environments and the source (version) of the installation, plus the possibility to use R. But the quick install is also a full installation itself
@glatterf42, since we both attempted to do the rename at the same time, we have diverged branches. I also made a few further copyedits, and added to the release notes, as these are substantial changes to the install instructions.
I've pushed to https://github.com/iiasa/message_ix/tree/update/install-instructions-2024-05 —can you incorporate these on your branch, please? Either pull that and force-push to your branch associated with the PR, or cherry-pick the commits, as you please.
Closes #771, #819, and #835.
In particular, this PR splits ours install guide into a
quick
guide based on several assumptions and afull
install guide with more background information.This PR emphasizes
pip
as the preferred installation method rather thanAnaconda
based on personal experience and preference.How to review
Installation
andFull Installation Guide
pages to check for correctness/style.PR checklist