iiasa / message_ix

The integrated assessment and energy systems model MESSAGEix
https://docs.messageix.org
Apache License 2.0
111 stars 149 forks source link

Update install instructions #843

Closed glatterf42 closed 4 weeks ago

glatterf42 commented 1 month ago

Closes #771, #819, and #835.

In particular, this PR splits ours install guide into a quick guide based on several assumptions and a full install guide with more background information.

This PR emphasizes pip as the preferred installation method rather than Anaconda based on personal experience and preference.

How to review

PR checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.6%. Comparing base (bdf5747) to head (6c5bc91).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #843 +/- ## ======================================= - Coverage 95.6% 95.6% -0.1% ======================================= Files 46 46 Lines 4335 4333 -2 ======================================= - Hits 4145 4143 -2 Misses 190 190 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/iiasa/message_ix/pull/843/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iiasa)
glatterf42 commented 4 weeks ago

As mentioned by @adrivinca just now, we want to make sure that the quick-install pip steps include information about java. Either explicitly calling out the assumption that it's installed or saying how it can be installed.

khaeru commented 4 weeks ago

I pushed some commits based on the following observations/ideas:

glatterf42 commented 4 weeks ago

Are there any commits missing from this PR? Because your comment states that you want to move the "Install from GitHub" section from quick to full install, but it is still visible in the quick install section of the recent RTD build for this PR.

glatterf42 commented 4 weeks ago

Also, there seem to be two notes in the RTD build output related to the latest changes:

/home/docs/checkouts/readthedocs.org/user_builds/iiasa-energy-program-message-ix/checkouts/843/doc/install-full.rst:41: WARNING: py:class reference target not found: JDBCBackend
/home/docs/checkouts/readthedocs.org/user_builds/iiasa-energy-program-message-ix/checkouts/843/doc/prereqs.rst:84: WARNING: undefined label: 'install-full'
adrivinca commented 4 weeks ago

thanks both for the great work. just a comment after reviewing the installation docs

Overall I think it looks good. I was a bit confused by this "quick" and "full" distinction, which gives the impression that if you do the quick install you don't have a full version of message_ix I would rename the "full" to "advanced", like in several software installation processes. The difference between the two installations seems simply that "full" is more advanced in terms of personalizing environments and the source (version) of the installation, plus the possibility to use R. But the quick install is also a full installation itself

khaeru commented 4 weeks ago

@glatterf42, since we both attempted to do the rename at the same time, we have diverged branches. I also made a few further copyedits, and added to the release notes, as these are substantial changes to the install instructions.

I've pushed to https://github.com/iiasa/message_ix/tree/update/install-instructions-2024-05 —can you incorporate these on your branch, please? Either pull that and force-push to your branch associated with the PR, or cherry-pick the commits, as you please.