Open glatterf42 opened 5 months ago
Attention: Patch coverage is 0%
with 255 lines
in your changes missing coverage. Please review.
Project coverage is 90.3%. Comparing base (
1125579
) to head (baeb7f8
). Report is 39 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
message_ix/tools/add_timeslice/add_timeslice.py | 0.0% | 255 Missing :warning: |
:exclamation: There is a different number of reports uploaded between BASE (1125579) and HEAD (baeb7f8). Click for more details.
HEAD has 133 uploads less than BASE
| Flag | BASE (1125579) | HEAD (baeb7f8) | |------|------|------| ||151|18|
In the MESSAGE meeting just now, @behnam-zakeri mentioned that https://github.com/iiasa/message_ix/pull/680 might be related.
@glatterf42 Related to the test, I have added an example of Westeros model via the Excel file, which is used by the code to create a Westeros scenario with time slices, exactly similar to the one we have in our published tutorials (Westeros_seasonality.ipynb). So, the only part missing will be to check if the output of these two models are the same or not.
This PR supersedes iiasa/message-ix-models#197 as @khaeru suggested this tool might be better placed in message_ix.
@behnam-zakeri Please take a look at the changes. Several things come to mind before merging this:
README.rst
as was done foradd_year
)How to review
Check the above boxes plus:
PR checklist